]> err.no Git - linux-2.6/commit
[PATCH] libata-eh: Remove layering violation and duplication when handling absent...
authorAlan Cox <alan@lxorguk.ukuu.org.uk>
Tue, 26 Sep 2006 16:53:38 +0000 (17:53 +0100)
committerJeff Garzik <jeff@garzik.org>
Tue, 26 Sep 2006 17:34:27 +0000 (13:34 -0400)
commitc961922b73dab429a759f560952fd4c3f60bd6b3
treecbd6d6424d508fd208ae9992c1cf11b3b8a91fb1
parent4735ebedf37731160e3d3efc9fc9d4939c66fefa
[PATCH] libata-eh: Remove layering violation and duplication when handling absent ports

This removes the layering violation where drivers have to fiddle
directly with EH flags. Instead we now recognize -ENOENT means "no port"
and do the handling in the core code.

This also removes an instance of a call to disable the port, and an
identical printk from each driver doing this. Even better - future rule
changes will be in one place only.

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
17 files changed:
drivers/ata/ata_piix.c
drivers/ata/libata-eh.c
drivers/ata/pata_amd.c
drivers/ata/pata_artop.c
drivers/ata/pata_atiixp.c
drivers/ata/pata_efar.c
drivers/ata/pata_jmicron.c
drivers/ata/pata_mpiix.c
drivers/ata/pata_ns87410.c
drivers/ata/pata_oldpiix.c
drivers/ata/pata_opti.c
drivers/ata/pata_optidma.c
drivers/ata/pata_pdc2027x.c
drivers/ata/pata_sis.c
drivers/ata/pata_sl82c105.c
drivers/ata/pata_triflex.c
drivers/ata/pata_via.c