]> err.no Git - linux-2.6/commit
S2io: Fix for LRO Bugs
authorSurjit Reang <surjit.reang@neterion.com>
Sun, 3 Feb 2008 12:27:38 +0000 (04:27 -0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 3 Feb 2008 12:27:38 +0000 (04:27 -0800)
commitc88559539bd16eae4e9056d4734b3fe8a9858c45
treea90ea2bc129d9e4d944f49fd669ab36c98a9f15d
parent03157ac31eb4a8883382a212b161d2e6c5059fbf
S2io: Fix for LRO Bugs

Resubmitting patch from Al Viro <viro@zeniv.linux.org.uk>, with subject -
[PATCH] s2io LRO bugs.
a) initiate_new_session() sets ->tcp_ack to ntohl(...); everything
   else stores and expects to find there the net-endian value.
b) check for monotonic timestamps in verify_l3_l4_lro_capable()
   compares the value sitting in TCP option (right there in the skb->data,
   net-endian 32bit) with the value picked from earlier packet.
   Doing that without ntohl() is an interesting idea and it might even
   work occasionally; unfortunately, it's quite broken.

Signed-off-by: Surjit Reang <surjit.reang@neterion.com>
Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/s2io.c
drivers/net/s2io.h