]> err.no Git - linux-2.6/commit
Fix a bad error case handling in read_cache_page_async()
authorDavid Howells <dhowells@redhat.com>
Wed, 9 May 2007 12:42:20 +0000 (13:42 +0100)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Wed, 9 May 2007 20:04:03 +0000 (13:04 -0700)
commitc855ff3718e5f667b463b20b9de516b4cd7625ad
tree5f5f2db132c80705db2254fc8f2f222160228aa5
parentaabded9c3aab5160ae2ca3dd1fa0fa37f3d510e4
Fix a bad error case handling in read_cache_page_async()

Commit 6fe6900e1e5b6fa9e5c59aa5061f244fe3f467e2 introduced a nasty bug
in read_cache_page_async().

It added a "mark_page_accessed(page)" at the final return path in
read_cache_page_async().  But in error cases, 'page' holds the error
code, and you can't mark it accessed.

[ and Glauber de Oliveira Costa points out that we can use a return
  instead of adding more goto's ]

Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/filemap.c