]> err.no Git - linux-2.6/commit
[AX.25]: Fix potencial memory hole.
authorRalf Baechle DL5RB <ralf@linux-mips.org>
Sun, 19 Mar 2006 21:20:06 +0000 (13:20 -0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 19 Mar 2006 21:20:06 +0000 (13:20 -0800)
commitc7c694d196a39af6e644e24279953d04f30362db
treecb78fead47ce86245179fe0a52119c70b30b59cb
parent60a6dc55b93b3321afa52f650a149fb7e87fa85a
[AX.25]: Fix potencial memory hole.

If the AX.25 dialect chosen by the sysadmin is set to DAMA master / 3
(or DAMA slave / 2, if CONFIG_AX25_DAMA_SLAVE=n) ax25_kick() will fall
through the switch statement without calling ax25_send_iframe() or any
other function that would eventually free skbn thus leaking the packet.

Fix by restricting the sysctl inferface to allow only actually supported
AX.25 dialects.

The system administration mistake needed for this to happen is rather
unlikely, so this is an uncritical hole.

Coverity #651.

Signed-off-by: Ralf Baechle DL5RB <ralf@linux-mips.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/ax25.h
net/ax25/sysctl_net_ax25.c