]> err.no Git - linux-2.6/commit
[POWERPC] Avoid possible extra of_node_put in axon_msi.c
authorStephen Rothwell <sfr@canb.auug.org.au>
Tue, 5 Feb 2008 02:13:15 +0000 (13:13 +1100)
committerPaul Mackerras <paulus@samba.org>
Wed, 6 Feb 2008 05:30:00 +0000 (16:30 +1100)
commitc6d01179bfee3048cce98fe303d7265faa3861a7
tree216faf6fffd748b761abd4feec307f5b3020e9dd
parentde4c928b843063b7079c35c950c1d38c559fa0cb
[POWERPC] Avoid possible extra of_node_put in axon_msi.c

I got this warning from gcc:
arch/powerpc/platforms/cell/axon_msi.c:118: warning: 'tmp' may be used uninitialized in this function

Which turns out to be a false positive, but pointed out that it was
possible for the error path in find_msi_translator() to do an extra
of_node_put on a node.  This fixes it by localising the ref counting
a bit.  As a side effect, the warning goes away.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/platforms/cell/axon_msi.c