]> err.no Git - linux-2.6/commit
scsi/gdth: fix crash in gdth_timeout if no gdth controllers found
authorLinus Torvalds <torvalds@woody.linux-foundation.org>
Mon, 15 Oct 2007 19:46:16 +0000 (12:46 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Mon, 15 Oct 2007 19:46:16 +0000 (12:46 -0700)
commitc596cc46ba1c5769866efe586daff3422bc31afe
tree080f0fc2fc91d6b37f1cf2992bab3d6720c748e1
parentf4921aff5b174349bc36551f142a5dbac782ea3f
scsi/gdth: fix crash in gdth_timeout if no gdth controllers found

If the gdth module is loaded (or compiled in), the gdth_timeout function
gets started even if no actual gdth controllers are found b the probing.

That ends up not only being unnecessary, but also causes a crash due to
the function blindly just trying to pick the first entry off the
"gdth_instances" list, and accessing it - which obviously doesn't work
if the list is empty!

Noticed by Ingo Molnar.

Tested-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/scsi/gdth.c