]> err.no Git - linux-2.6/commit
usb: ehci should use u16 for isochronous intervals
authorDavid Brownell <david-b@pacbell.net>
Thu, 24 Jan 2008 20:30:34 +0000 (12:30 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 1 Feb 2008 22:35:06 +0000 (14:35 -0800)
commitc06d4dcf5034ee2289a921b9b2c547f3fed2d878
treeced2640ecaa9b8a9a2e3ce8fdfcaf16b6f1568bc
parentcd4cdc93ce04b562412df6c0cf25c564ab2522ac
usb: ehci should use u16 for isochronous intervals

While most isochronous endpoints have short polling intervals, the
EHCI driver won't necessarily handle larger ones correctly.

This patch switches to use a "u16" to represent those periods, not
a u8, since it can always work:  the largest expressible period
is 2^15 units ... not the previous too-short limit of 128 frames
(full or low speeds) or microframes (high speed, 32 frames).

This bug is essentially theoretical, since the few ISO endpoints
I've seen which don't use one transfer per frame are high speed
ones using more than that (including high bandwidth, 24 KB/msec).

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/host/ehci.h