]> err.no Git - linux-2.6/commit
pl2303: Fix mode switching regression
authorAlan Cox <alan@lxorguk.ukuu.org.uk>
Tue, 8 Jan 2008 14:55:51 +0000 (14:55 +0000)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Wed, 9 Jan 2008 00:16:34 +0000 (16:16 -0800)
commitbf5e5834bffc62b50cd4a201804506eb11ef1af8
tree09cd94995a4c67b0fd84f7c81b7f2bb58fac8e50
parentcf0594625083111ae522496dc1c256f7476939c2
pl2303: Fix mode switching regression

Cleaning out all the incorrect 'no change made' checks for termios
settings showed up a problem with the PL2303. The hardware here seems to
lose sync and bits if you tell it to make no changes. This shows up with
a real world application.

To fix this the driver check for meaningful hardware changes is restored
but doing the tests correctly and as a tty layer function so it doesn't
get duplicated wrongly everywhere if other drivers turn out to need it.

Signed-off-by: Alan Cox <alan@redhat.com>
Tested-by: Mirko Parthey <mirko.parthey@informatik.tu-chemnitz.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/char/tty_ioctl.c
drivers/usb/serial/pl2303.c
include/linux/tty.h