]> err.no Git - linux-2.6/commit
[PATCH] fbdev: Fix incorrect unaligned access in little-endian machines
authorAntonino A. Daplas <adaplas@gmail.com>
Tue, 13 Dec 2005 06:17:21 +0000 (22:17 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Tue, 13 Dec 2005 06:31:17 +0000 (22:31 -0800)
commitbe0d9b6c7aeaad1683059c00131cabd4c894c17c
treef7e55af855531331113cbddb98688f3901d48425
parent7275b4b6bc2f783c135c3f0eeecc4fdc6e788aa8
[PATCH] fbdev: Fix incorrect unaligned access in little-endian machines

The drawing function cfbfillrect does not work correctly when access is not
unsigned-long aligned.  It manifests as extra lines of pixels that are not
complete drawn.  Reversing the shift operator solves the problem, so I would
presume that this bug would manifest only on little endian machines.  The
function cfbcopyarea may also have this bug.

Aligned access should present no problems.

Signed-off-by: Antonino Daplas <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/video/cfbcopyarea.c
drivers/video/cfbfillrect.c
drivers/video/cfbimgblt.c
include/linux/fb.h