]> err.no Git - linux-2.6/commit
cdrom: handle TOC
authorAlexander Inyukhin <shurick@sectorb.msk.ru>
Mon, 18 Aug 2008 19:40:04 +0000 (21:40 +0200)
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Mon, 18 Aug 2008 19:40:04 +0000 (21:40 +0200)
commitbce31b674846584f0a80c95b6c09f07c32b9b041
tree71267e419702863709e7c2ca4b81ecf2570b31aa
parentd15cad5df1dac17ae33152646f599f0bdc6be48e
cdrom: handle TOC

This patch should fix TOC handling for cdroms that can not play audio.  It
extends commit af744e3294d09d706c4eae26cffaaa68a8d40337 ("cdrom: don't
check CDC_PLAY_AUDIO in cdrom_count_tracks()") with a safety check and
non-audio ioctls support.

Since CDC_PLAY_AUDIO flag was used not only to check ability to play audio
but also to ensure that audio_ioctl was not NULL, all TOC-related
operations had to use it.

As far as I understand, now audio_ioctl is never NULL, so a sanity check
during device registration should be sufficient.

It was tested on Optiarc AD7203A device, that has no ability to play
audio.

Cc: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Borislav Petkov <petkovbb@googlemail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
[bart: remove now unneeded ->audio_ioctl check (noticed by Borislav)]
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
drivers/cdrom/cdrom.c