]> err.no Git - varnish/commit
Fix an embarrasing bug in my Flexlinting of this code yesterday, and
authorphk <phk@d4fa192b-c00b-0410-8231-f00ffab90ce4>
Tue, 2 Dec 2008 20:48:11 +0000 (20:48 +0000)
committerphk <phk@d4fa192b-c00b-0410-8231-f00ffab90ce4>
Tue, 2 Dec 2008 20:48:11 +0000 (20:48 +0000)
commitb9a382cd5a0b9bad0f43159702e89faffd553ed1
treea5f6836cf121c794ca5baf93bf60db92e3e7ee24
parenta7c177bbf4f4154a0025797d9efa9cbade93162e
Fix an embarrasing bug in my Flexlinting of this code yesterday, and
add a couple of test-vectors to avoid it happening again.

And now for the funny and educational story:

In july of 1994, I added the "libmd" to FreeBSD, containing the
MD2, MD4 and MD5 functions from RFC 1319, RFC 1186 and RFC1321.

I meticulously replicated the test-vectors from the RFCs, so that
"make test" would validate the result.

Duing the intermediate 14 years, various slight shifts and adjustments
to things like the make(1) programs defaults, the shared library
resolution algorithm and other totally unrelated things, meant that
"make test" now tests the installed version of the library, rather
than the version you just built with "make all".

Needless to say, when I tested my patch yesterday, I didn't install
the built version, wanting first to hear what Colin Percival, FreeBSD
Security Wiz, generally swell fella and the guy who wrote this
SHA256 implementation, thought of these "stylistic" patches.

git-svn-id: svn+ssh://projects.linpro.no/svn/varnish/trunk@3452 d4fa192b-c00b-0410-8231-f00ffab90ce4
varnish-cache/include/vsha256.h
varnish-cache/lib/libvarnish/vsha256.c