]> err.no Git - linux-2.6/commit
[PATCH] USB: ehci: fix bogus alteration of a local variable
authorDavid Brownell <david-b@pacbell.net>
Fri, 30 Jun 2006 09:34:42 +0000 (02:34 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 12 Jul 2006 23:03:23 +0000 (16:03 -0700)
commitb972b68c396cfa9f8af7e0b314e22705251bc218
tree5cd84d901fdeb4921593521197eee57ab066e2b9
parent69de51fdda3fd984541978313b66e4f2c44cc23e
[PATCH] USB: ehci: fix bogus alteration of a local variable

In a rare and all-but-unused path, the EHCI driver could reuse a variable
in a way that'd make trouble.  Specifically, if the first root hub port
gets an overcurrent event (rare) during a remote wakeup scenario (all but
unused in today's Linux, except for folk working with suspend-to-RAM and
similar sleep states), that would look like a fatal error which would shut
down the controller.  Fix by not reusing that variable.

Spotted by Per Hallsmark <saxofon@musiker.nu>
Fixes http://bugzilla.kernel.org/show_bug.cgi?id=6661

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/host/ehci-hcd.c