]> err.no Git - linux-2.6/commit
USB: fix usb-serial generic recursive lock
authorPete Zaitcev <zaitcev@redhat.com>
Wed, 5 Mar 2008 07:28:42 +0000 (23:28 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 10 Mar 2008 23:42:25 +0000 (16:42 -0700)
commitb507cc9710d8b6e3013468b40522e235342fc84a
tree9543c5e06c1d1fb6890d2520b876bf9828c367a6
parentcdeeeae056a429e729ae9e914fa8142ee45bee93
USB: fix usb-serial generic recursive lock

Nobody should be using the generic usb-serial for anything other than
testing. Still, it's not a good thing that it's easy to lock up. There
is a traceback from NMI oopser here:
 https://bugzilla.redhat.com/show_bug.cgi?id=431379

But in short, if a line discipline has a chance to echo anything, input
can loop back a write method. So, don't call tty_flip_buffer_push from
under a lock taken on write path.

Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/serial/generic.c