]> err.no Git - linux-2.6/commit
[SCSI] Simplify error handling
authorMatthew Wilcox <matthew@wil.cx>
Tue, 28 Mar 2006 16:03:44 +0000 (11:03 -0500)
committerJames Bottomley <jejb@mulgrave.il.steeleye.com>
Thu, 13 Apr 2006 15:13:25 +0000 (10:13 -0500)
commitb4e93a739ed1352664defd41d5e4f82afa29b928
tree1799983732dd5dbedd59eb69661f11f49a7f1217
parentc2349df918cdfd47dfe6afaaeed9f504b83255d0
[SCSI] Simplify error handling

Use wait_for_completion_timeout() instead of using a timer (as
Christoph Hellwig did for aic7xxx).

That lets me eliminate the sym_eh_wait structure; the struct completion,
the old_done pointer and the to_do flag can be folded into the sym_ucmd
(which overrides the scsi_pointer in scsi_cmnd).

The sym_eh_done() function becomes much simpler as the timeout handling
is done in sym_eh_handler() directly.

The host_lock can be unlocked earlier, and I cache the host in
a local variable to make accesses to it quicker.

Signed-off-by: Matthew Wilcox <matthew@wil.cx>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
drivers/scsi/sym53c8xx_2/sym_glue.c