]> err.no Git - linux-2.6/commit
[PATCH] __get_page_state() cpumask cleanup and fix
authorAndrew Morton <akpm@osdl.org>
Wed, 22 Mar 2006 08:07:39 +0000 (00:07 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Wed, 22 Mar 2006 15:53:55 +0000 (07:53 -0800)
commitb40607fc02f8248828d52d88f91b7d68df1933b0
tree4e29b252e6bf8d520de092edfeb9bc60413d92cb
parent68ed0040a8c9d06b73cda322a1f740749bd6e41a
[PATCH] __get_page_state() cpumask cleanup and fix

__get_page_state() has an open-coded for_each_cpu_mask() loop in it.

Tidy that up, then notice that the code was buggy:

while (cpu < NR_CPUS) {
unsigned long *in, *out, off;

if (!cpu_isset(cpu, *cpumask))
continue;

an obvious infinite loop.  I guess we just never call it with a holey cpu
mask.

Even after my cpumask size-reduction work, this patch increases code size :(

Cc: Paul Jackson <pj@sgi.com>
Cc: Christoph Lameter <clameter@engr.sgi.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
mm/page_alloc.c