]> err.no Git - linux-2.6/commit
isapnp: remove pointless check of 'type' against 0 in isapnp_read_tag()
authorJesper Juhl <jesper.juhl@gmail.com>
Mon, 16 Jul 2007 06:41:53 +0000 (23:41 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Mon, 16 Jul 2007 16:05:52 +0000 (09:05 -0700)
commitb2111217df52827916141789c87d614ae45236db
treeb947351d6b5f744d6d7f261729ebefcad97df71d
parent3f1b0e1f287547903f11fa1e6de7d2765597766e
isapnp: remove pointless check of 'type' against 0 in isapnp_read_tag()

In drivers/pnp/isapnp/core.c::isapnp_read_tag() there is a test of 'type'
being == 0 a bit down in the function.  That test doesn't make any sense.
If 'type' could indeed be NULL, then the test happens way too late as we'd
already have tried to dereference the pointer earlier and looking at the
callers it also turns out that there is no way type can ever actually be
NULL.

So the test is completely pointless and should just be removed.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/pnp/isapnp/core.c