]> err.no Git - linux-2.6/commit
[POWERPC] Remove gratuitous reads from pasemi pci config space methods
authorNathan Lynch <ntl@pobox.com>
Thu, 9 Aug 2007 21:37:27 +0000 (07:37 +1000)
committerPaul Mackerras <paulus@samba.org>
Fri, 17 Aug 2007 01:01:54 +0000 (11:01 +1000)
commitb139f1fb0f1e4bfe06f2c88ba8c9a55d9513d871
treef0483fecba0a1f756357457e19692830cdc5bc36
parent8935fa0fe6f87c4df806f605de04aed4353c7600
[POWERPC] Remove gratuitous reads from pasemi pci config space methods

The pasemi pci configuration space write method reads the written
location immediately after the write is performed, presumably in order
to flush the write.  However, configuration space writes are not
allowed to be posted, making these reads gratuitous.  Furthermore,
this behavior potentially causes us to violate the PCI PM spec when
changing between e.g. D0 and D3 states, because a delay of up to 10ms
may be required before the OS accesses configuration space after the
write which initiates the transition.

Remove the unnecessary reads from pa_pxp_write_config.

Signed-off-by: Nathan Lynch <ntl@pobox.com>
Acked-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/platforms/pasemi/pci.c