]> err.no Git - linux-2.6/commit
[JFFS2] fix deadlock on error path
authorArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
Wed, 21 Mar 2007 09:07:05 +0000 (11:07 +0200)
committerDavid Woodhouse <dwmw2@infradead.org>
Tue, 17 Apr 2007 17:53:51 +0000 (13:53 -0400)
commitb0afbbec4981417f79e05865a36e57abfc289002
treeb0e14a643310de8e1232859f5b4af3effe3a7ea6
parent4226b510371efd9cdc628663527d36aee36054a9
[JFFS2] fix deadlock on error path

When the MTD driver returns write failure, the following deadlock
occurs:

We are in __jffs2_flush_wbuf(), we hold &c->wbuf_sem. Write failure.
jffs2_wbuf_recover()->jffs2_reserve_space_gc()->jffs2_do_reserve_space()
->jffs2_erase_pending_blocks()->jffs2_flash_read()

and it tries to lock &c->wbuf_sem again. Deadlock.

Reported-by: Adrian Hunter <ext-adrian.hunter@nokia.com>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
fs/jffs2/erase.c