]> err.no Git - linux-2.6/commit
[PATCH] tmpfs: fix mount mpol nodelist parsing
authorHugh Dickins <hugh@veritas.com>
Tue, 21 Feb 2006 23:49:47 +0000 (23:49 +0000)
committerLinus Torvalds <torvalds@g5.osdl.org>
Wed, 22 Feb 2006 01:10:15 +0000 (17:10 -0800)
commitb00dc3ad74fdb676552d46ee573b88e927240d0c
tree6dcf7806f1f0fc791d3455dcf233a11088b18b3a
parent808c783e9bfb217a90be5a996a867c41a69b40bd
[PATCH] tmpfs: fix mount mpol nodelist parsing

I've been dissatisfied with the mpol_nodelist mount option which was
added to tmpfs earlier in -rc.  Replace it by mpol=policy:nodelist.

And it was broken: a nodelist is a comma-separated list of numbers and
ranges; the mount options are a comma-separated list of token=values.
Whoops, blindly strsep'ing on commas doesn't work so well: since we've
no numeric tokens, and unlikely to add them, use that to distinguish.

Move the mpol= parsing to shmem_parse_mpol under CONFIG_NUMA, reject
all its options as invalid if not NUMA.  /proc shows MPOL_PREFERRED
as "prefer", so use that name for the policy instead of "preferred".

Enforce that mpol=default has no nodelist; that mpol=prefer has one
node only; that mpol=bind has a nodelist; but let mpol=interleave use
node_online_map if no nodelist given.  Describe this in tmpfs.txt.

Signed-off-by: Hugh Dickins <hugh@veritas.com>
Acked-by: Robin Holt <holt@sgi.com>
Acked-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Documentation/filesystems/tmpfs.txt
mm/shmem.c