]> err.no Git - linux-2.6/commit
[PATCH] i386/x86-64: Work around gcc bug with noreturn functions in unwinder
authorJan Beulich <jbeulich@novell.com>
Tue, 26 Sep 2006 08:52:41 +0000 (10:52 +0200)
committerAndi Kleen <andi@basil.nowhere.org>
Tue, 26 Sep 2006 08:52:41 +0000 (10:52 +0200)
commitadf1423698f00d00b267f7dca8231340ce7d65ef
treeec2e28a32d467cc3c618c8ee0cedd3d1a49f9c43
parentab2e0b46cb9a197fab7d98e147cac7cd41a14047
[PATCH] i386/x86-64: Work around gcc bug with noreturn functions in unwinder

Current gcc generates calls not jumps to noreturn functions. When that happens the
return address can point to the next function, which confuses the unwinder.

This patch works around it by marking asynchronous exception
frames in contrast normal call frames in the unwind information.  Then teach
the unwinder to decode this.

For normal call frames the unwinder now subtracts one from the address which avoids
this problem.  The standard libgcc unwinder uses the same trick.

It doesn't include adjustment of the printed address (i.e. for the original
example, it'd still be kernel_math_error+0 that gets displayed, but the
unwinder wouldn't get confused anymore.

This only works with binutils 2.6.17+ and some versions of H.J.Lu's 2.6.16
unfortunately because earlier binutils don't support .cfi_signal_frame

[AK: added automatic detection of the new binutils and wrote description]

Signed-off-by: Jan Beulich <jbeulich@novell.com>
Signed-off-by: Andi Kleen <ak@suse.de>
arch/i386/Makefile
arch/i386/kernel/entry.S
arch/x86_64/Makefile
arch/x86_64/ia32/ia32entry.S
arch/x86_64/kernel/entry.S
include/asm-i386/dwarf2.h
include/asm-i386/unwind.h
include/asm-x86_64/dwarf2.h
include/asm-x86_64/unwind.h
kernel/unwind.c
scripts/Kbuild.include