]> err.no Git - linux-2.6/commit
Initialise scatter/gather list in ata_sg_setup
authorAnton Blanchard <anton@samba.org>
Fri, 26 Oct 2007 11:59:44 +0000 (13:59 +0200)
committerJens Axboe <jens.axboe@oracle.com>
Mon, 29 Oct 2007 08:18:03 +0000 (09:18 +0100)
commitacd054a5ef401e03e0047b487e572442614f81e5
tree000704c359643885e3b0fd4e6d082321d5889ccb
parent5336940dd8b11180a0340ba886db62f728377d19
Initialise scatter/gather list in ata_sg_setup

After turning on DEBUG_SG I hit a fail:

kernel BUG at include/linux/scatterlist.h:50!

ata_qc_issue
ata_scsi_translate
ipr_queuecommand
scsi_dispatch_cmd
scsi_request_fn
elv_insert
blk_execute_rq_nowait
blk_execute_rq
sg_io
scsi_cmd_ioctl
cdrom_ioctl
sr_block_ioctl
blkdev_driver_ioctl
blkdev_ioctl
block_ioctl
do_ioctl
vfs_ioctl
sys_ioctl
sg_ioctl_trans

It looks like ata_sg_setup is working on an uninitialised sg table. Call
sg_init_table to initialise it before use.

Signed-off-by: Anton Blanchard <anton@samba.org>
Note: this patch will fix it, but you could also get away with just
doing the sg_init_table() once at qc creation time.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
drivers/ata/libata-core.c