]> err.no Git - linux-2.6/commit
[PATCH] Avoid namespace pollution in <asm/param.h>
authorDag-Erling Smørgrav <des@linpro.no>
Mon, 2 Jan 2006 14:57:06 +0000 (15:57 +0100)
committerLinus Torvalds <torvalds@g5.osdl.org>
Mon, 2 Jan 2006 16:38:38 +0000 (08:38 -0800)
commitabe842eb98c45e2b77c5868ef106616ca828a3e4
treef0d89e7d946a7ed9b57bb29e93bae4ce25d2cbc2
parentf12f4d90308a22396ac87f6c3a7b2620589614c3
[PATCH] Avoid namespace pollution in <asm/param.h>

In commit 3D59121003721a8fad11ee72e646fd9d3076b5679c, the x86 and x86-64
<asm/param.h> was changed to include <linux/config.h> for the
configurable timer frequency.

However, asm/param.h is sometimes used in userland (it is included
indirectly from <sys/param.h>), so your commit pollutes the userland
namespace with tons of CONFIG_FOO macros.  This greatly confuses
software packages (such as BusyBox) which use CONFIG_FOO macros
themselves to control the inclusion of optional features.

After a short exchange, Christoph approved this patch

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
include/asm-i386/param.h
include/asm-x86_64/param.h