]> err.no Git - linux-2.6/commit
firewire: don't respond to broadcast write requests
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Sun, 25 May 2008 09:06:55 +0000 (11:06 +0200)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Mon, 14 Jul 2008 11:06:03 +0000 (13:06 +0200)
commita7ea67823af4a7e442e92064b0fab46603a588f6
treef6d67468a3a363ee6753b11a4e6656b454b5fe98
parent459f79235d8faa0050180c7e0c7bb4b2b52cbdfd
firewire: don't respond to broadcast write requests

Contrary to a comment in the source, request->ack of a broadcast write
request can be ACK_PENDING.  Hence the existing check is insufficient.

Debug dmesg before:
AR spd 0 tl 00, ffc0 -> ffff, ack_pending , QW req, fffff0000234 = ffffffff
AT spd 0 tl 00, ffff -> ffc0, ack_complete, W resp
And the requesting node (linux1394) reports an unsolicited response.

Debug dmesg after:
AR spd 0 tl 00, ffc0 -> ffff, ack_pending , QW req, fffff0000234 = ffffffff

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
drivers/firewire/fw-transaction.c