]> err.no Git - linux-2.6/commit
[libata] change ata_qc_complete() to take error mask as second arg
authorJeff Garzik <jgarzik@pobox.com>
Sun, 30 Oct 2005 09:44:42 +0000 (04:44 -0500)
committerJeff Garzik <jgarzik@pobox.com>
Sun, 30 Oct 2005 09:44:42 +0000 (04:44 -0500)
commita7dac447bb9cef27d4d29cdf63e2d7809c50b1f4
treea8935490cdd374aba3a804ba9f79d1aed67db36d
parent81cfb8864c73230eb1c37753aba517db15cf4d8f
[libata] change ata_qc_complete() to take error mask as second arg

The second argument to ata_qc_complete() was being used for two
purposes: communicate the ATA Status register to the completion
function, and indicate an error.  On legacy PCI IDE hardware, the latter
is often implicit in the former.  On more modern hardware, the driver
often completely emulated a Status register value, passing ATA_ERR as an
indication that something went wrong.

Now that previous code changes have eliminated the need to use drv_stat
arg to communicate the ATA Status register value, we can convert it to a
mask of possible error classes.

This will lead to more flexible error handling in the future.
drivers/scsi/ahci.c
drivers/scsi/libata-core.c
drivers/scsi/libata-scsi.c
drivers/scsi/libata.h
drivers/scsi/pdc_adma.c
drivers/scsi/sata_mv.c
drivers/scsi/sata_promise.c
drivers/scsi/sata_qstor.c
drivers/scsi/sata_sil24.c
drivers/scsi/sata_sx4.c
include/linux/libata.h