]> err.no Git - linux-2.6/commit
[PATCH] I2C: #include <linux/config.h> cleanup
authorJean Delvare <khali@linux-fr.org>
Sat, 16 Apr 2005 16:49:22 +0000 (18:49 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 22 Jun 2005 04:51:53 +0000 (21:51 -0700)
commita551ef79d9413727f76d22dc47b5b15d1d03073b
tree4b43e032dc6b6cb5de78ce700b12762ab71483e0
parentf0bb60e7b1a0a26c25d8cbf81dda7afbc8bd2982
[PATCH] I2C: #include <linux/config.h> cleanup

Hi Alexey,

> Files that don't use CONFIG_* stuff shouldn't include config.h
> Files that use CONFIG_* stuff should include config.h
>
> It's that simple. ;-)

I agree. This won't change anything though, as all drivers include
either device.h or module.h, which in turn include config.h. But you are
still correct, so I approve your patch.

For completeness, I would propose the following on top of your own
patch:

i2c bus drivers do not need to define DEBUG themselves, as the Kconfig
system takes care of it.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/i2c/busses/i2c-ixp2000.c
drivers/i2c/busses/i2c-ixp4xx.c