]> err.no Git - linux-2.6/commit
[TG3]: Fix possible NULL deref in tg3_run_loopback().
authorJesper Juhl <jesper.juhl@gmail.com>
Wed, 10 May 2006 06:14:35 +0000 (23:14 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 10 May 2006 06:14:35 +0000 (23:14 -0700)
commita50bb7b9af9a7c39b2aba15678eb686ae428718c
treef741922e4dbc4920548d7d4b68cf5eb37c11f85e
parent8c1056839e808aad728db86d739ffec71d2d1db8
[TG3]: Fix possible NULL deref in tg3_run_loopback().

tg3_run_loopback doesn't check that dev_alloc_skb() returns anything
useful.

Even if dev_alloc_skb() fails to return an skb to us we'll happily go
on and assume it did, so we risk dereferencing a NULL pointer.  Much
better to fail gracefully by returning -ENOMEM than crashing here.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/tg3.c