]> err.no Git - linux-2.6/commit
dev_printk and new-style class devices
authorJean Delvare <khali@linux-fr.org>
Fri, 9 Mar 2007 15:33:10 +0000 (16:33 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 27 Apr 2007 17:57:28 +0000 (10:57 -0700)
commita456b7023e0abf80bb03b0bdf5471b48878e5c49
tree8e9034c4538e5fa9ae6914691430c6aedfc7e6bf
parent864062457a2e444227bd368ca5f2a2b740de604f
dev_printk and new-style class devices

As the new-style class devices (as opposed to old-style struct
class_device) are becoming more widely used, I noticed that the
dev_printk-based functions are not working properly with these.
New-style class devices have no driver nor bus, almost by definition,
and as a result dev_driver_string(), which is used as the first
parameter of dev_printk, resolves to an empty string. This causes
entries like the following to show in my logs:

 i2c-2: adapter [SMBus stub driver] registered

Notice the unaesthetical leading whitespace. In order to fix this
problem, I suggest that we extend dev_driver_string to deal with
new-style class devices:

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/base/core.c