]> err.no Git - linux-2.6/commit
[NETFILTER]: nfnetlink_queue: fix checks in nfqnl_recv_config
authorPatrick McHardy <kaber@trash.net>
Wed, 5 Dec 2007 09:28:30 +0000 (01:28 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 28 Jan 2008 22:56:18 +0000 (14:56 -0800)
commita3c8e7fd4b36bf6e12fef432cfa8a001dc0b7a26
tree59ce4404b88b5b20bd7a6e344d3b3dc77c81ad9e
parente48b9b2fb383879a5d758d526b5eb8de4509f467
[NETFILTER]: nfnetlink_queue: fix checks in nfqnl_recv_config

The peer_pid must be checked in all cases when a queue exists, currently
it is not checked if for NFQA_CFG_QUEUE_MAXLEN when a NFQA_CFG_CMD
attribute exists in some cases. Same for the queue existance check,
which can cause a NULL pointer dereference.

Also consistently return -ENODEV for "queue not found". -ENOENT would
be better, but that is already used to indicate a queued skb id doesn't
exist.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netfilter/nfnetlink_queue.c