]> err.no Git - linux-2.6/commit
[SCSI] Signedness issue in drivers/scsi/ipr.c
authorEric Sesterhenn <snakebyte@gmx.de>
Mon, 25 Sep 2006 23:59:07 +0000 (16:59 -0700)
committerJames Bottomley <jejb@mulgrave.il.steeleye.com>
Tue, 26 Sep 2006 18:35:36 +0000 (11:35 -0700)
commita2a65a3ecb54ecd1a8f0409f11cb82ae083c6964
treecb4cf44eae7dc53a2951aaf32f76c5b93b5280c4
parentdcbccbde00b85b4d4a1c206b419e7a3d2ab2b1cd
[SCSI] Signedness issue in drivers/scsi/ipr.c

gcc 4.1 with some extra warnings show the following:

drivers/scsi/ipr.c:6361: warning: comparison of unsigned expression < 0 is always false
drivers/scsi/ipr.c:6385: warning: comparison of unsigned expression < 0 is always false
drivers/scsi/ipr.c:6415: warning: comparison of unsigned expression < 0 is always false

The problem is that rc is of the type u32, which can never be smaller than
zero, therefore all three error handling checks get useless.  This patch
changes it to a normal int, because all usages / all functions it get used
with expect an int.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Acked-by: Brian King <brking@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
drivers/scsi/ipr.c