]> err.no Git - linux-2.6/commit
AGP fix race condition between unmapping and freeing pages
authorDave Airlie <airlied@redhat.com>
Mon, 15 Oct 2007 00:19:16 +0000 (10:19 +1000)
committerDave Airlie <airlied@optimus.(none)>
Mon, 15 Oct 2007 00:32:15 +0000 (10:32 +1000)
commita2721e998ede079db10f65e4b42310f79dc8f135
tree32963c9bf40f3e0871d4d549bb6c3cf13abbb24c
parent23fd50450a34f2558070ceabb0bfebc1c9604af5
AGP fix race condition between unmapping and freeing pages

With Andi's clflush fixup, we were getting hangs on server exit, flushing the
mappings after freeing each page helped.

This showed up a race condition where the pages after being freed could be
reused before the agp mappings had been flushed.  Flushing after each single
page is a bad thing for future drm work, so make the page destroy a two pass
unmapping all the pages, flushing the mappings, and then destroying the pages.

Signed-off-by: Dave Airlie <airlied@linux.ie>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/char/agp/agp.h
drivers/char/agp/ali-agp.c
drivers/char/agp/backend.c
drivers/char/agp/generic.c
drivers/char/agp/i460-agp.c
drivers/char/agp/intel-agp.c