]> err.no Git - linux-2.6/commit
[PATCH] abituguru: Review fixes
authorHans de Goede <j.w.r.degoede@hhs.nl>
Sun, 4 Jun 2006 18:23:01 +0000 (20:23 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 22 Jun 2006 18:10:34 +0000 (11:10 -0700)
commita2392e0b907b9633c31be14ee75bb39fce348b01
tree7e393e1c53b7f26c87d871fd9eb401b0f4369d7d
parentf2b84bbcebfdbe4855bab532909eef6621999f9f
[PATCH] abituguru: Review fixes

Fixes to the Abit uGuru driver as requested in review by Jean Delvare:
 - exactly calculate the sysfs_names array length using macro
 - use snprintf when generating names to double check that the sysfs_names
   array does not overflow.
 - use ARRAY_SIZE and / or defines to determine number of loops in for loops
   instead of using hardcoded values.
 - In abituguru_probe(), refactor the error path leaving a single call to kfree

Signed-off-by: Hans de Goede <j.w.r.degoede@hhs.nl>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/hwmon/abituguru.c