]> err.no Git - linux-2.6/commit
sched: fix SysRq-N (normalize RT tasks)
authorIngo Molnar <mingo@elte.hu>
Sun, 17 Jun 2007 16:37:45 +0000 (18:37 +0200)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Mon, 18 Jun 2007 18:52:55 +0000 (11:52 -0700)
commita0f98a1cb7d27c656de450ba56efd31bdc59065e
tree8ff6c211cd190aa6152e8ef4bd9f142277ed4a9f
parent4cc21505a09354ade787de368bd697a1bba3b213
sched: fix SysRq-N (normalize RT tasks)

Gene Heskett reported the following problem while testing CFS: SysRq-N
is not always effective in normalizing tasks back to SCHED_OTHER.

The reason for that turns out to be the following bug:

 - normalize_rt_tasks() uses for_each_process() to iterate through all
   tasks in the system.  The problem is, this method does not iterate
   through all tasks, it iterates through all thread groups.

The proper mechanism to enumerate over all threads is to use a
do_each_thread() + while_each_thread() loop.

Reported-by: Gene Heskett <gene.heskett@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/sched.c