]> err.no Git - linux-2.6/commit
projects / linux-2.6 / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 5ee33b7) | patch
[PATCH] Wrong return value corrupts free object in e1000 driver
authorDavid S. Miller <davem@davemloft.net>
Sat, 11 Mar 2006 02:08:09 +0000 (18:08 -0800)
committerJeff Garzik <jeff@garzik.org>
Sat, 11 Mar 2006 18:25:17 +0000 (13:25 -0500)
commit9e927fb6186b6913d47d33068160088a084d568e
tree4ecd5584f82fbda06cfe6c162505b59ba4391915tree | snapshot
parent5ee33b7adc178dbeb16b4d8303ae3ab69a334518commit | diff
[PATCH] Wrong return value corrupts free object in e1000 driver

For some reason, E1000's ->hard_start_xmit() routine returns -EFAULT
instead of one of the NETDEV_TX_* error codes.  In fact, it frees up
the SKB before returning this.  This makes the queueing layer think
the packet should be requeued and subsequently we corrupt a freed
object.

Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/net/e1000/e1000_main.c diff | blob | history
Linux 2.6 source tree