]> err.no Git - linux-2.6/commit
V4L/DVB (6238): bw-qcam: use data_reverse instead of manually poking the control...
authorBrett Warden <brett.warden@gmail.com>
Fri, 28 Sep 2007 06:19:04 +0000 (03:19 -0300)
committerMauro Carvalho Chehab <mchehab@infradead.org>
Wed, 10 Oct 2007 01:14:50 +0000 (22:14 -0300)
commit9e19db5b6dda251b8d76c3a0069e63faca6be3f0
tree9fad0f372d62415867083168a24f709961de3d87
parent0b67f5c568c545cb36f88e9f418af2df1cc58589
V4L/DVB (6238): bw-qcam: use data_reverse instead of manually poking the control register

Fixes use of parport_write_control() to match the newer interface that
requires explicit parport_data_reverse() and parport_data_forward() calls.
This eliminates the following error message and restores the original
intended behavior:

parport0 (bw-qcam): use data_reverse for this!

Also increases threshold in qc_detect() from 300 to 400, as my camera often
results in a count of approx 330.  Added a kernel error message to indicate
detection failure.

Thanks Ray and Randy for your comments, and for pointing out that I
needed to reset the port to forward mode!

Signed-off-by: Brett T. Warden <brett.warden@gmail.com>
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
drivers/media/video/bw-qcam.c