]> err.no Git - linux-2.6/commit
pvr2fb: Fix oops when pseudo_palette is written
authorAntonino A. Daplas <adaplas@gmail.com>
Fri, 10 Aug 2007 20:00:47 +0000 (13:00 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Sat, 11 Aug 2007 22:47:40 +0000 (15:47 -0700)
commit9cd1c67434544b1d9a4fb4a4cdec15608167a233
tree04c872c916fc26e78b7a492f5ecfa681e641d2fc
parent4769a9a53b39f3b6a7e4d0b3c5e6b9598560818d
pvr2fb: Fix oops when pseudo_palette is written

Reported by: Adrian McMenamin <adrianmcmenamin@gmail.com>

This driver will oops when the pseudo_palette[] is written as u32 but not when
written as u16.  When written as u32, it corrupts the adjacent 'mmio_base'
field of struct pvr2fb_par.  Fix by using framebuffer_alloc()/release() to
allocate struct fb_info and struct pvr2fb_par, and create the pseudo_palette[]
as part of struct pvr2fb_par.

Signed-off-by: Antonino Daplas <adaplas@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/video/pvr2fb.c