]> err.no Git - linux-2.6/commit
[PATCH] lockdep: debug_show_all_locks & debug_show_held_locks vs. debug_locks
authorJarek Poplawski <jarkao2@o2.pl>
Thu, 22 Mar 2007 08:11:28 +0000 (00:11 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Fri, 23 Mar 2007 02:39:06 +0000 (19:39 -0700)
commit9c35dd7f8bda1849dcb430be99325504221048df
tree0c1d8eef5af9e21bf9c552f13646710f57b97f23
parentb43376927ab0f7b64c4fb304568ecfaea10446e2
[PATCH] lockdep: debug_show_all_locks & debug_show_held_locks vs. debug_locks

lockdep's data shouldn't be used when debug_locks == 0 because it's not
updated after this, so it's more misleading than helpful.

PS: probably lockdep's current-> fields should be reset after it turns
debug_locks off: so, after printing a bug report, but before return from
exported functions, but there are really a lot of these possibilities (e.g.
 after DEBUG_LOCKS_WARN_ON), so, something could be missed.  (Of course
direct use of this fields isn't recommended either.)

Reported-by: Folkert van Heusden <folkert@vanheusden.com>
Inspired-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Jarek Poplawski <jarkao2@o2.pl>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/lockdep.c