]> err.no Git - linux-2.6/commit
[PATCH] vfs: MS_VERBOSE should be MS_SILENT
authorTheodore Ts'o <tytso@mit.edu>
Fri, 24 Mar 2006 11:15:10 +0000 (03:15 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Fri, 24 Mar 2006 15:33:15 +0000 (07:33 -0800)
commit9b04c997b1120feefa1e6ee8e2902270bc055cd2
tree09376b68d11ccce2a1ef53bac25a41a763ad36d0
parent6961ec8267d08e21011457b05d2263ec06bdcfe1
[PATCH] vfs: MS_VERBOSE should be MS_SILENT

The meaning of MS_VERBOSE is backwards; if the bit is set, it really means,
"don't be verbose".  This is confusing and counter-intuitive.

In addition, there is also no way to set the MS_VERBOSE flag in the
mount(8) program in util-linux, but interesting, it does define options
which would do the right thing if MS_SILENT were defined, which
unfortunately we do not:

#ifdef MS_SILENT
  { "quiet",    0, 0, MS_SILENT    },   /* be quiet  */
  { "loud",     0, 1, MS_SILENT    },   /* print out messages. */
#endif

So the obvious fix is to deprecate the use of MS_VERBOSE and replace it
with MS_SILENT.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/afs/super.c
fs/cifs/cifsfs.c
fs/jffs2/super.c
fs/nfs/inode.c
fs/super.c
include/linux/fs.h
init/do_mounts.c