]> err.no Git - linux-2.6/commit
[PATCH] x86: consolidate smp_send_stop()
authorJan Beulich <jbeulich@novell.com>
Wed, 2 May 2007 17:27:05 +0000 (19:27 +0200)
committerAndi Kleen <andi@basil.nowhere.org>
Wed, 2 May 2007 17:27:05 +0000 (19:27 +0200)
commit9964cf7d776600724ef5f1b33303ceadc588b8ba
tree80cf8f027b251ed5243d4f8e2219782abfe18df6
parentb0354795c9c8fef2fadf8f867586c78efd9a1dc9
[PATCH] x86: consolidate smp_send_stop()

Synchronize i386's smp_send_stop() with x86-64's in only try-locking
the call lock to prevent deadlocks when called from panic().
In both version, disable interrupts before clearing the CPU off the
online map to eliminate races with IRQ handlers inspecting this map.
Also in both versions, save/restore interrupts rather than disabling/
enabling them.
On x86-64, eliminate one function used here by folding it into its
single caller, convert to static, and rename for consistency with i386
(lkcd may like this).

Signed-off-by: Jan Beulich <jbeulich@novell.com>
Signed-off-by: Andi Kleen <ak@suse.de>
arch/i386/kernel/smp.c
arch/x86_64/kernel/smp.c
include/asm-x86_64/smp.h