]> err.no Git - linux-2.6/commit
PCI: Flush MSI-X table writes
authorMitch Williams <mitch.a.williams@intel.com>
Fri, 30 Mar 2007 18:54:08 +0000 (11:54 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 3 May 2007 02:02:34 +0000 (19:02 -0700)
commit988cbb15e00e6f924d052874b40c6a5447f9fdd7
treea4bea1a5cdbfd8321463cc50b5539bebd4b01155
parentdc87c3985e9b442c60994308a96f887579addc39
PCI: Flush MSI-X table writes

This patch fixes a kernel bug which is triggered when using the
irqbalance daemon with MSI-X hardware.

Because both MSI-X interrupt messages and MSI-X table writes are posted,
it's possible for them to cross while in-flight.  This results in
interrupts being received long after the kernel thinks they're disabled,
and in interrupts being sent to stale vectors after rebalancing.

This patch performs a read flush after writes to the MSI-X table for
mask and unmask operations.  Since the SMP affinity is set while
the interrupt is masked, and since it's unmasked immediately after,
no additional flushes are required in the various affinity setting
routines.

This patch has been validated with (unreleased) network hardware which
uses MSI-X.

Revised with input from Eric Biederman.

Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/pci/msi.c