]> err.no Git - linux-2.6/commit
[PATCH] chardev: GPIO for SCx200 & PC-8736x: add platforn_device for use w dev_dbg
authorJim Cromie <jim.cromie@gmail.com>
Tue, 27 Jun 2006 09:54:14 +0000 (02:54 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Wed, 28 Jun 2006 00:32:42 +0000 (17:32 -0700)
commit979b5ec3a7055d35b212f657e80257ec1346aa0e
tree41c47b988d6302218fa71a7d8ca7f21b9fa95826
parent7d7f212661d68d231fdfaead03dda0dd44d5bbbb
[PATCH] chardev: GPIO for SCx200 & PC-8736x: add platforn_device for use w dev_dbg

Add a platform-device to scx200_gpio, and use its struct device dev member
(ie: devp) in dev_dbg() once.

There are 2 alternatives here (Im soliciting guidance/commentary):

- use isa_device, if/when its added to the kernel.

- alter scx200.c to EXPORT_GPL its private devp so that both scx200_gpio,
  and the (to be added) nsc_gpio module can use it.  Since the available devp
  is in 'grandparent', this seems like too much 'action at a distance'.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/char/scx200_gpio.c