]> err.no Git - linux-2.6/commit
[NETLINK]: cb_lock does not needs ref count on sk
authorHerbert Xu <herbert@gondor.apana.org.au>
Tue, 3 May 2005 21:43:27 +0000 (14:43 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 3 May 2005 21:43:27 +0000 (14:43 -0700)
commit96c36023434b7b6824b1da72a6b7b1ca61d7310c
tree21b46ccc9e88f5ab77e0578356ba7d86e0f5c964
parent9dfa277f88388a94993b121db46b80df66f48d9e
[NETLINK]: cb_lock does not needs ref count on sk

Here is a little optimisation for the cb_lock used by netlink_dump.
While fixing that race earlier, I noticed that the reference count
held by cb_lock is completely useless.  The reason is that in order
to obtain the protection of the reference count, you have to take
the cb_lock.  But the only way to take the cb_lock is through
dereferencing the socket.

That is, you must already possess a reference count on the socket
before you can take advantage of the reference count held by cb_lock.
As a corollary, we can remve the reference count held by the cb_lock.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netlink/af_netlink.c