]> err.no Git - linux-2.6/commit
[TCP]: Make sure write_queue_from does not begin with NULL ptr
authorIlpo Järvinen <ilpo.jarvinen@helsinki.fi>
Wed, 14 Nov 2007 23:47:18 +0000 (15:47 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 14 Nov 2007 23:47:18 +0000 (15:47 -0800)
commit96a2d41a3e495734b63bff4e5dd0112741b93b38
tree4190a560eabaa8dd6a78c1bf2d43515605954874
parentfb93134dfc2a6e6fbedc7c270a31da03fce88db9
[TCP]: Make sure write_queue_from does not begin with NULL ptr

NULL ptr can be returned from tcp_write_queue_head to cached_skb
and then assigned to skb if packets_out was zero. Without this,
system is vulnerable to a carefully crafted ACKs which obviously
is remotely triggerable.

Besides, there's very little that needs to be done in sacktag
if there weren't any packets outstanding, just skipping the rest
doesn't hurt.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_input.c