]> err.no Git - linux-2.6/commit
ipv4/fib_hash.c: fix NULL dereference
authorAdrian Bunk <bunk@kernel.org>
Wed, 20 Feb 2008 00:28:54 +0000 (16:28 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 20 Feb 2008 00:28:54 +0000 (16:28 -0800)
commit94cb1503c799c0197e7ef5bad606fee5c84b99d8
treedb9969ea8bf142e4c4a7621d0bc9382c42537686
parent15e29b8b0542f28fc0feed2d60e0377b39a45c4f
ipv4/fib_hash.c: fix NULL dereference

Unless I miss a guaranteed relation between between "f" and
"new_fa->fa_info" this patch is required for fixing a NULL dereference
introduced by commit a6501e080c318f8d4467679d17807f42b3a33cd5 ("[IPV4]
FIB_HASH: Reduce memory needs and speedup lookups") and spotted by the
Coverity checker.

Eric Dumazet says:

Hum, you are right, kmem_cache_free() doesnt allow a NULL
object, like kfree() does.

Signed-off-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/fib_hash.c