]> err.no Git - linux-2.6/commit
W1: w1_therm.c ds18b20 decode freezing temperatures correctly
authorDavid Fries <david@fries.net>
Tue, 22 Jan 2008 11:31:37 +0000 (03:31 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Tue, 22 Jan 2008 17:17:48 +0000 (09:17 -0800)
commit941ed3b53086697eac7449f3ab5d2c5ab3259de2
treecd0192ab9a6ab906edc59be1ccf92df49b206c9a
parentd384e35a25445bb60457b7dab8cffe178c6b7ecb
W1: w1_therm.c ds18b20 decode freezing temperatures correctly

Correct the decoding of negative C temperatures.  The code did a binary OR
of two bytes to make a 16 bit value, but assignd it to an integer.  This
caused the value to not be sign extended and to loose that it was a
negative number in the assignment.

Before the patch (in my freezer),
w1_slave
ed fe 4b 46 7f ff 03 10 e4 : crc=e4 YES
ed fe 4b 46 7f ff 03 10 e4 t=4078
With the patch,
e3 fe 4b 46 7f ff 0d 10 81 : crc=81 YES
e3 fe 4b 46 7f ff 0d 10 81 t=-17

Signed-off-by: David Fries <david@fries.net>
Acked-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/w1/slaves/w1_therm.c