]> err.no Git - linux-2.6/commit
arch/m68k/mm/sun3mmu.c: Eliminate NULL test and memset after alloc_bootmem
authorJulia Lawall <julia@diku.dk>
Thu, 17 Jul 2008 19:16:34 +0000 (21:16 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 21 Jul 2008 00:24:40 +0000 (17:24 -0700)
commit93026e217b46b70f9719caf69e716fa3bbe1d20c
tree25b927d68c9aff1cb306cf46d4c2460c12da9547
parent7b6b948fc0d60a704c15b1cd72345a98e759dd62
arch/m68k/mm/sun3mmu.c: Eliminate NULL test and memset after alloc_bootmem

As noted by Akinobu Mita in patch b1fceac2b9e04d278316b2faddf276015fc06e3b,
alloc_bootmem and related functions never return NULL and always return a
zeroed region of memory.  Thus a NULL test or memset after calls to these
functions is unnecessary.

This was fixed using the following semantic patch.
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
expression E;
statement S;
@@

E = \(alloc_bootmem\|alloc_bootmem_low\|alloc_bootmem_pages\|alloc_bootmem_low_pages\)(...)
.. when != E
(
- BUG_ON (E == NULL);
|
- if (E == NULL) S
)

@@
expression E,E1;
@@

E = \(alloc_bootmem\|alloc_bootmem_low\|alloc_bootmem_pages\|alloc_bootmem_low_pages\)(...)
.. when != E
- memset(E,0,E1);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/m68k/mm/sun3mmu.c