]> err.no Git - linux-2.6/commit
x86/pci: fix broken ISA DMA
authorTakashi Iwai <tiwai@suse.de>
Mon, 12 May 2008 13:43:30 +0000 (15:43 +0200)
committerIngo Molnar <mingo@elte.hu>
Mon, 12 May 2008 19:27:50 +0000 (21:27 +0200)
commit8965eb19386fdf5ccd0ef8b02593eb8560aa3416
tree8107a8db856d7b02b8b4d7bb88e53db1df8344ef
parent492c2e476eac010962850006c49df326919b284c
x86/pci: fix broken ISA DMA

Rene Herman reported:

> commit 8779f2fc3b84ebb6c5181fb13d702e9944c16069
>
> "x86: don't try to allocate from DMA zone at first"
>
> breaks all of ISA DMA. Or all of ALSA ISA DMA at least. All
> ISA soundcards are silent following that commit -- no error
> messages, everything appears fine, just silence.

That patch is buggy. We had an implicit assumption that
dev = NULL for ISA devices that require 24bit DMA.

The recent work on x86 dma_alloc_coherent() breaks the ISA DMA buffer
allocation, which is represented by "dev = NULL" and requires 24bit
DMA implicitly.

Bisected-by: Rene Herman <rene.herman@keyaccess.nl>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Tested-by: Rene Herman <rene.herman@keyaccess.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/kernel/pci-dma.c