]> err.no Git - linux-2.6/commit
projects / linux-2.6 / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 8a03d9a) | patch
rio: typo in bitwise AND expression.
authorWilly Tarreau <w@1wt.eu>
Sat, 17 Feb 2007 17:57:09 +0000 (18:57 +0100)
committerAdrian Bunk <bunk@stusta.de>
Sat, 17 Feb 2007 17:57:09 +0000 (18:57 +0100)
commit88dacbe961aa63fa880b4f6f16515427f61fc3ca
tree8431bf7a9665144aea0970f10565e683a5bbce7ctree | snapshot
parent8a03d9a498eaf02c8a118752050a5154852c13bfcommit | diff
rio: typo in bitwise AND expression.

The line :

    hp->Mode &= !RIO_PCI_INT_ENABLE;

is obviously wrong as RIO_PCI_INT_ENABLE=0x04 and is used as a bitmask
2 lines before. Getting no IRQ would not disable RIO_PCI_INT_ENABLE
but rather RIO_PCI_BOOT_FROM_RAM which equals 0x01.

Obvious fix is to change ! for ~.

Signed-off-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
drivers/char/rio/rio_linux.c diff | blob | history
Linux 2.6 source tree