]> err.no Git - linux-2.6/commit
scsi: fix dependency bug in aic7 Makefile
authorSam Ravnborg <sam@ravnborg.org>
Sun, 3 Feb 2008 20:55:49 +0000 (21:55 +0100)
committerSam Ravnborg <sam@ravnborg.org>
Sun, 3 Feb 2008 20:55:49 +0000 (21:55 +0100)
commit8891fec65ac5b5a74b50c705e31b66c92c3eddeb
tree9d931442ea3e7a31152a897e0fdc9e443e193f2b
parentba3d05fb6369e617aee4f16bfce7ba5cbd30f26b
scsi: fix dependency bug in aic7 Makefile

Building the aic7xxx driver includes the copy
of an .h file from a _shipped file.

In a highly parallel build Ingo saw that the
build sometimes failed (included distcc usage).
It was tracked down to a missing dependency from the .c
source file to the generated .h file.
We started to build the .c file before the
copy (cat) operation of the .h file completed
and we then only got half of the definitions
from the copied .h file.

Add an explicit dependency from the .c files to the
generated .h files so make knows all dependencies and
finsih the build of the .h files before it starts
building the .o files.

Ingo tested this fix and reported:
good news: hundreds of successful kernel builds and no failures
overnight.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Ingo Molnar <mingo@elte.hu>
Acked-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/aic7xxx/Makefile