]> err.no Git - linux-2.6/commit
[TCP]: reno sacked_out count fix
authorAngelo P. Castellani <angelo.castellani+lkml@gmail.com>
Wed, 17 May 2006 04:42:11 +0000 (21:42 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 17 May 2006 04:42:11 +0000 (21:42 -0700)
commit8872d8e1c4311dd7e5086975df9c76120a0be83b
tree1486697e32c65521785721fe9523f4eaee9a3e90
parentd8fd0a73169e90022dc3ccf3083ca24573b44b5c
[TCP]: reno sacked_out count fix

From: "Angelo P. Castellani" <angelo.castellani+lkml@gmail.com>

Using NewReno, if a sk_buff is timed out and is accounted as lost_out,
it should also be removed from the sacked_out.

This is necessary because recovery using NewReno fast retransmit could
take up to a lot RTTs and the sk_buff RTO can expire without actually
being really lost.

left_out = sacked_out + lost_out
in_flight = packets_out - left_out + retrans_out

Using NewReno without this patch, on very large network losses,
left_out becames bigger than packets_out + retrans_out (!!).

For this reason unsigned integer in_flight overflows to 2^32 - something.

Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_input.c