]> err.no Git - linux-2.6/commit
nfsd: more careful input validation in nfsctl write methods
authorJ. Bruce Fields <bfields@citi.umich.edu>
Tue, 22 Jan 2008 22:40:42 +0000 (17:40 -0500)
committerJ. Bruce Fields <bfields@citi.umich.edu>
Fri, 1 Feb 2008 21:42:15 +0000 (16:42 -0500)
commit87d26ea7771ad637035e6bd5a2700d81ee9162da
treec1da6cd6fe03bfadb3276bd30423c7d4b105ef41
parent50431d94e732ba71b66a83c5435890728e313095
nfsd: more careful input validation in nfsctl write methods

Neil Brown points out that we're checking buf[size-1] in a couple places
without first checking whether size is zero.

Actually, given the implementation of simple_transaction_get(), buf[-1]
is zero, so in both of these cases the subsequent check of the value of
buf[size-1] will catch this case.

But it seems fragile to depend on that, so add explicit checks for this
case.

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Acked-by: NeilBrown <neilb@suse.de>
fs/nfsd/nfsctl.c